Skip to content

Update ktx2 to v0.5.0#23900

Merged
alice-i-cecile merged 8 commits intobevyengine:mainfrom
JMS55:ktx2-0.5
May 2, 2026
Merged

Update ktx2 to v0.5.0#23900
alice-i-cecile merged 8 commits intobevyengine:mainfrom
JMS55:ktx2-0.5

Conversation

@JMS55
Copy link
Copy Markdown
Contributor

@JMS55 JMS55 commented Apr 20, 2026 •
edited
Loading

Updated ktx2 crate.

After doing so, Bevy ktx2 files failed to validate due to invalid metadata. I fixed all their metadata, and made sure they passed ktx validate.

@JMS55 JMS55 requested a review from rparrett April 20, 2026 17:00
@JMS55 JMS55 added A-Assets Load files from disk to use for things like images, models, and sounds C-Dependencies A change to the crates that Bevy depends on labels Apr 20, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Assets Apr 20, 2026
@JMS55 JMS55 requested a review from alice-i-cecile April 20, 2026 17:02
@alice-i-cecile alice-i-cecile added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Apr 20, 2026
@alice-i-cecile
Copy link
Copy Markdown
Member

alice-i-cecile commented Apr 20, 2026

Example run failure looks real.

@alice-i-cecile alice-i-cecile added X-Uncontroversial This work is generally agreed upon S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 20, 2026
@JMS55 JMS55 added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Apr 20, 2026
@JMS55 JMS55 marked this pull request as draft April 20, 2026 19:08
@JMS55 JMS55 marked this pull request as ready for review May 1, 2026 23:59
@JMS55 JMS55 requested a review from mockersf May 2, 2026 00:00
@JMS55 JMS55 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 2, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 2, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 2, 2026
@JMS55 JMS55 mentioned this pull request May 2, 2026
Open
@alice-i-cecile alice-i-cecile enabled auto-merge May 2, 2026 01:27
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 2, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 2, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 2, 2026
Merged via the queue into bevyengine:main with commit 4898189 May 2, 2026
42 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Assets May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rparrett rparrett Awaiting requested review from rparrett

@alice-i-cecile alice-i-cecile Awaiting requested review from alice-i-cecile

@mockersf mockersf Awaiting requested review from mockersf

2 more reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

@andriyDev andriyDev andriyDev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

Assets
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JMS55 @alice-i-cecile @cwfitzgerald @andriyDev