Skip to content

Allow bsn! scene inheritance to use paths with generics#23902

Merged
cart merged 2 commits intobevyengine:mainfrom
eugineerd:scene-inheritance-with-generics
Apr 20, 2026
Merged

Allow bsn! scene inheritance to use paths with generics#23902
cart merged 2 commits intobevyengine:mainfrom
eugineerd:scene-inheritance-with-generics

Conversation

@eugineerd
Copy link
Copy Markdown
Contributor

@eugineerd eugineerd commented Apr 20, 2026

Objective

support generics in bsn! scene inheritance syntax (i.e. :some_scene::<T>)

Solution

Parse Path instead of an Ident for scene inheritance

Testing

added inheritance_with_generics test to bevy_scene/src/lib.rs

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Scenes Composing and serializing ECS objects D-Straightforward Simple bug fixes and API improvements, docs, test and examples D-Macros Code that generates Rust code labels Apr 20, 2026
@cart cart added this pull request to the merge queue Apr 20, 2026
Merged via the queue into bevyengine:main with commit 9312a1b Apr 20, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cart cart cart approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

No one assigned

Labels

A-Scenes Composing and serializing ECS objects C-Bug An unexpected or incorrect behavior D-Macros Code that generates Rust code D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eugineerd @cart @alice-i-cecile