Add bevy_transform benchmarks#23906
Merged
alice-i-cecile merged 6 commits intobevyengine:mainfrom Apr 21, 2026
Merged
Conversation
Sieluna
changed the title
bevy_transform benchmarks and align feature gates
alice-i-cecile
added
C-Code-Quality
Member
|
I really like both of these changes, but can you please split them into two separate PRs to make them easier to review? :) |
Sieluna
changed the title
bevy_transform benchmarks and align feature gatesbevy_transform benchmarks
Contributor
Author
Thanks for the suggestion. I've rebased this PR onto the latest upstream, and it now only includes the benchmark. The other part will be moved to a separate PR. |
alice-i-cecile
removed
the
C-Code-Quality
alice-i-cecile
approved these changes
Apr 21, 2026
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Benchmarks look fine to me, and I think that including dedicated micro-benchmarks for this is very reasonable.
The Cargo.toml change needs to reverted for this PR though :)
This reverts commit 052a06a.
alice-i-cecile
added
the
D-Straightforward
ickshonpe
suggested changes
Apr 21, 2026
ickshonpe
reviewed
Apr 21, 2026
Contributor
There was a problem hiding this comment.
I haven't written any benchmarks before using criterion (at least that I can recall) but this looks very well constructed to me, except for the minor nit about the schedule ordering.
It'd be nice if we could set up something similar for UI transforms and layout.
Co-Authored-By: ickshonpe <27962798+ickshonpe@users.noreply.github.com>
ickshonpe
approved these changes
Apr 21, 2026
kfc35
added
S-Ready-For-Final-Review
pull Bot
pushed a commit
to orzogc/bevy
that referenced
this pull request
Apr 22, 2026
# Objective `bevy_transform`'s multi-threading behavior was previously gated on `feature = "std"`, which incorrectly conflated standard library availability with multi-threading capability. This means: - Users who enabled `no_std` but had multi-threading available lost parallelism unintentionally. - Users who had `std` but wanted single-threaded execution (e.g. WASM) still attempted to use the parallel path. - `bevy_internal`'s `multi_threaded` feature did not propagate down to `bevy_transform`, so the parallel implementation was not activated when expected. - The `bevy_log` dependency was pulled in unconditionally via the `std` feature, when the only use was optional trace-level warnings. ## Solution - Added an explicit `multi_threaded` feature to `bevy_transform`, backed by `bevy_tasks/multi_threaded`, matching the pattern used by `bevy_ecs` and other crates. - Replaced all `#[cfg(feature = "std")]` / `#[cfg(not(feature = "std"))]` guards on parallel/serial code paths with `#[cfg(all(not(target_arch = "wasm32"), feature = "multi_threaded"))]` / `#[cfg(any(target_arch = "wasm32", not(feature = "multi_threaded")))]` — the same guard pattern already used in `bevy_ecs`. - Added `bevy_transform/multi_threaded` to `bevy_internal`'s and `bevy_render`'s `multi_threaded` feature lists so parallel transforms are activated end-to-end when building Bevy with `multi_threaded`. - Removed the `bevy_log` dependency from `bevy_transform`. Its sole usage was a `warn_once!` inside `propagate_transforms_for`. This is replaced with a direct `tracing::warn!` wrapped in `bevy_utils::once!`, gated on a new opt-in `trace` feature (`dep:tracing`). This keeps the default build lighter. - Inlined the `trace` feature spans in `mark_dirty_trees` that previously depended on `bevy_log`'s re-exported `tracing`, now using `tracing` directly under `#[cfg(feature = "trace")]`. ## Testing - All existing unit tests in `bevy_transform::systems::test` pass unchanged — no behavioral changes, only cfg guard corrections. - No performance regressions observed by [Benchmark](bevyengine#23906). --- --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy_transform's propagation systems to catch performance regressions.Solution
Benchmarks (
benches/benches/bevy_transform/propagate.rs):Added small benchmarks targeting each stage of the propagation pipeline individually.
mark_dirty_trees— localized vs. distributed leaf update patternspropagate_parent_transforms— full recompute with roots changed vs. leaves changed (static optimization disabled to isolate traversal cost)transform_pipeline— end-to-end pipeline with static optimization on/off, plusChildOfreparent churnThe hierarchy setup uses 48 roots × 6 depth layers with mixed fanout (4-4-3-3-2-2) and extra archetype padding (
MarkerA/B/C) to reflect realistic gameplay scenes.Testing