Don't panic in AssetPath deserialization#23935
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Apr 22, 2026
Merged
Don't panic in AssetPath deserialization#23935alice-i-cecile merged 3 commits intobevyengine:mainfrom
AssetPath deserialization#23935alice-i-cecile merged 3 commits intobevyengine:mainfrom
Conversation
… when taking ownership of the string.
alice-i-cecile
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
AssetPathdeserialization panics if the path is malformed. This seems a bit rude, and prevents the user from getting deserialization errors that would help track down the problem.Solution
Instead of calling
AssetPath::parse, callAssetPath::try_parseand handle any errors.Now, calling
ron::de::from_stron"a/b.test#"returns a useful error:The PR also removes the
visit_stringmethod of theAssetPathdeserializer.visit_stringis an optimization that avoids copies when the deserializer can take ownership of the string (see serde docs). ButAssetPathdidn't take ownership of the string, so there's no reason to implement it.Testing
cargo test -p bevy_asset cargo run --example world_serialization