Rely on Default + Clone auto-impl for FromTemplate where possible#23940
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Apr 22, 2026
Merged
Rely on Default + Clone auto-impl for FromTemplate where possible#23940alice-i-cecile merged 1 commit intobevyengine:mainfrom
alice-i-cecile merged 1 commit intobevyengine:mainfrom
Conversation
cart
added
C-Code-Quality
alice-i-cecile
approved these changes
Apr 22, 2026
alice-i-cecile
added
the
S-Ready-For-Final-Review
fallible-algebra
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective / Solution
FromTemplatederive to mostbevy_ui_widgetscomponents #23924Manual FromTemplate derives are unnecessary for anything that doesn't require custom template logic. Letting a type be a template for itself is less confusing, has fewer corner cases, and does less codegen.
The rule of thumb to follow is "Use
Default + Clonefor anything that doesn't need custom template logic". In the case of #23924, the only type that needs custom template logic isScrollbar, because it has thetarget: Entityfield, which benefits from having an "entity template".