Fixes for camera output swap chain acquisition and view target rendering#23959
Merged
alice-i-cecile merged 8 commits intobevyengine:mainfrom Apr 25, 2026
Merged
Conversation
tychedelia
added
C-Bug
alice-i-cecile
requested changes
Apr 23, 2026
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Very reasonable defensive programming, but needs a quick migration guide.
alice-i-cecile
added
S-Waiting-on-Author
kfc35
approved these changes
Apr 23, 2026
kfc35
added
S-Needs-Review
Zeophlite
approved these changes
Apr 25, 2026
Zeophlite
added
S-Ready-For-Final-Review
alice-i-cecile
requested changes
Apr 25, 2026
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Migration guides moved; try again :)
alice-i-cecile
added
S-Waiting-on-Author
JMS55
added
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Apr 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discovered in Processing when using GLFW as a windowing backend that sometimes a window is reported as occluded for the first several frames. When a camera is configured with
ClearColorConfig::None, this can be problematic as the first several frames are skipped and thus do not accumulate drawing state in theViewTargettexture. In general, when the user requests a color attachment withLoadsemantics, we should do our best to make sure that we write into that texture, as missing/dropped frames my result in visually incorrect output.A few related fixes:
out_textureandOptioninViewTarget. A valid render target texture is not required in order to render if the user has requested view targetLoadsemantics. We still skip rendering when the user has requestedClearas this output will be overwritten anyway, saving some energy (i.e. preserves the previous behavior).CameraOutputMode::Writeto a swapchain. This should help avoid weirdness where we acquire but don't do work on a swapchain texture.