Improve default colors for text_input widgets#23960
Improve default colors for text_input widgets#23960alice-i-cecile merged 8 commits intobevyengine:mainfrom
Conversation
|
One "nice to have" would be to highlight the border color of the focused text input |
Unfortunately, that's not something that is the hands of EditableText. While it would be possible to modify the example to do this, it would complicated the example unnecessarily. Feathers, by contrast, uses the outline on the parent entity to indicate input focus, because the feathers text input has an outer frame which holds both the actual text input entity and the adornments. |
|
One more bit of followup, in #23947 (tokens::TEXT_INPUT_SELECTION, palette::ACCENT),
(
tokens::TEXT_INPUT_SELECTION_UNFOCUSED,
palette::ACCENT.lighter(0.2),
),This looks like
Someone with a design eye should say if this is distinct enough |
|
My personal preference would be:
|
|
OK let me be clear: when I was speaking of having the unfocused selection rect be fully transparent, I was only speaking in the context of feathers. For the non-feathers example, I can see how we would want to display the full capabilities of the EditableText component. More specifically, feathers needs to be judicious in its use of color: the idea is that the widgets should be readable, but should not distract from the star of the show - the media or game scene being edited. It should not call attention to itself - except for cases like primary buttons, where it is intentionally calling attention to itself. The non-feathers example, OTOH, just has to look pretty. |
|
LGTM |


Objective
Fixes #23955.
Solution
text_inputexample so it's both simpler and looks much better.Testing
cargo run --example text_inputShowcase
Before:
After: