Fix GhostNode updates#24001
Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom Apr 28, 2026
Merged
Conversation
…hment. Collect the parents of entities that had `GhostNode` added or removed since the last layout update and update their children in the taffy tree..
ickshonpe
added
D-Straightforward
Zeophlite
approved these changes
Apr 27, 2026
kfc35
approved these changes
Apr 28, 2026
Contributor
kfc35
left a comment
kfc35
left a comment
There was a problem hiding this comment.
“dirty ghost children” is going to be a phrase I will remember randomly
kfc35
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The UI node and Taffy node trees aren't synchronised correctly after
GhostNodes are added, removed, or detached.Solution
Collect the closest non-ghost ancestor of entities where
GhostNodewas added or removed since the last layout update, and update their corresponding children in the taffy tree.Testing
Un
#[ignore]ed the failing ghost node tests and they pass now: