Merge LTC and DFG LUTs into a texture array#24004
Merge LTC and DFG LUTs into a texture array#24004beicause wants to merge 3 commits intobevyengine:mainfrom
Conversation
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
|
Do we want to keep the Edit: If we decide replace point light implementation with ltc #23400, then we should not gate ltc otherwise neither point light nor rect light can be used. |
|
This PR, after having main merged into it, currently fixes #23975 for me (since it reduces the number of SampledTextures) However, since it’s still a WIP, I won’t place it into the milestone yet until I reconfirm after it is back to being ready for review (Although I think putting back the feature gating will still keep the sampledTextures number lower than the limit?) |
|
I prefer #24065 to gate ltc luts. |
Objective
Reduce texture bindings in mesh view bind group.
Solution
Merge LTC and DFG LUTs into a texture array and remove
dfg_lutfeature.Since #23288 adds luts,
bevy_pbrshould enablebevy_image/ktx2andbevy_image/zstd.The
ltc_dfg.ktx2is created using KTX-Sofeware, DFG lut is converted from Rg16Float to Rgba16Float:Testing
Run
testbed_3d. Solari is untested.