Skip to content

Fix TypePath derive counting as a usage for deprecated types.#24011

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
andriyDev:type-path-dep
Apr 28, 2026
Merged

Fix TypePath derive counting as a usage for deprecated types.#24011
alice-i-cecile merged 1 commit intobevyengine:mainfrom
andriyDev:type-path-dep

Conversation

@andriyDev
Copy link
Copy Markdown
Contributor

Objective

  • Deprecating a type deriving TypePath would cause the type itself to trigger a deprecation lint. You couldn't even set #[allow(deprecated)]!

Solution

  • Add #[allow(deprecated)] to the generated code of TypePath.

Testing

  • The type I was deprecating stopped giving me lint warnings with this.

@andriyDev andriyDev added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Reflection Runtime information about types S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 28, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 28, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 28, 2026
Merged via the queue into bevyengine:main with commit a0b1ea2 Apr 28, 2026
49 checks passed
@andriyDev andriyDev deleted the type-path-dep branch April 28, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Reflection Runtime information about types C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants