Fallible arithmetic for Val and Val2#24014
Merged
alice-i-cecile merged 7 commits intobevyengine:mainfrom Apr 28, 2026
Merged
Conversation
alice-i-cecile
added
A-UI
alice-i-cecile
added
the
S-Needs-Review
alice-i-cecile
approved these changes
Apr 28, 2026
kfc35
approved these changes
Apr 28, 2026
kfc35
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Add fallible arithmetic support for
Vals.Solution
Implement
try_addandtry_submethods forValandVal2.The methods succeed only if the
Vals are matching variants, and neither isVal:Auto.I considered allowing arithmetric with incompatible zero(s), but it feels potentially confusing as there isn't a clear and natural way to select the units for the result.
Also removed the
val_arithmetic_error_messagestest, instead of updating it. I don't see any value there.