Fix: Add SyncComponents for SSAO, ensuring SSAOResources is synced

[kfc35]

Objective

• The SSAO part of the fix for view bindgroup layout changes can cause crash #24084

Solution

• Add SSAOResources (and other related components) to the sync component target for SSAO to ensure that adding/removing SSAO also adds/removes resources. This ensures that checking for SSAOResources later in mesh_view_bindings logic is valid.

Testing

• cargo run --example ssao : toggling “Off” no longer crashes.

[JMS55]

Comment seems kinda redundant, but approved.

[kfc35]

I’ll remove the comment, I can be excessively verbose 😅

[beicause]

The issue means ScreenSpaceAmbientOcclusionResources is not removed if ScreenSpaceAmbientOcclusion is removed.

Could you try adding extract_component_sync_target((Self, ScreenSpaceAmbientOcclusionResources, SsaoPipelineId, SsaoBindGroups))?

bevy/crates/bevy_pbr/src/ssao/mod.rs

Lines 111 to 115 in ce2bf99

	#[derive(Component, ExtractComponent, Reflect, PartialEq, Clone, Debug)]
	#[reflect(Component, Debug, Default, PartialEq, Clone)]
	#[require(DepthPrepass, NormalPrepass)]
	#[doc(alias = "Ssao")]
	pub struct ScreenSpaceAmbientOcclusion {

[kfc35]

Yep that works, so I switched to using sync components as opposed to checking for the regular component.

I had to make the bindgroups and pipeline id pub to accommodate. There are other places where such structs are also pub so I figured it doesn’t hurt.