[Merged by Bors] - rename example change_detection to have unique name#2419
Closed
mockersf wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - rename example change_detection to have unique name#2419mockersf wants to merge 1 commit intobevyengine:mainfrom
mockersf wants to merge 1 commit intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Jun 30, 2021
alice-i-cecile
added
C-Code-Quality
NathanSWard
approved these changes
Jun 30, 2021
mockersf
force-pushed
the
unique-example-name
branch
from
b386d09 to
840a163
Compare
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
# Objective Noticed a warning when running tests: ``` > cargo test --workspace warning: output filename collision. The example target `change_detection` in package `bevy_ecs v0.5.0 (/bevy/crates/bevy_ecs)` has the same output filename as the example target `change_detection` in package `bevy v0.5.0 (/bevy)`. Colliding filename is: /bevy/target/debug/examples/change_detection The targets should have unique names. Consider changing their names to be unique or compiling them separately. This may become a hard error in the future; see <rust-lang/cargo#6313>. warning: output filename collision. The example target `change_detection` in package `bevy_ecs v0.5.0 (/bevy/crates/bevy_ecs)` has the same output filename as the example target `change_detection` in package `bevy v0.5.0 (/bevy)`. Colliding filename is: /bevy/target/debug/examples/change_detection.dSYM The targets should have unique names. Consider changing their names to be unique or compiling them separately. This may become a hard error in the future; see <rust-lang/cargo#6313>. ``` ## Solution I renamed example `change_detection` to `component_change_detection`
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
# Objective Noticed a warning when running tests: ``` > cargo test --workspace warning: output filename collision. The example target `change_detection` in package `bevy_ecs v0.5.0 (/bevy/crates/bevy_ecs)` has the same output filename as the example target `change_detection` in package `bevy v0.5.0 (/bevy)`. Colliding filename is: /bevy/target/debug/examples/change_detection The targets should have unique names. Consider changing their names to be unique or compiling them separately. This may become a hard error in the future; see <rust-lang/cargo#6313>. warning: output filename collision. The example target `change_detection` in package `bevy_ecs v0.5.0 (/bevy/crates/bevy_ecs)` has the same output filename as the example target `change_detection` in package `bevy v0.5.0 (/bevy)`. Colliding filename is: /bevy/target/debug/examples/change_detection.dSYM The targets should have unique names. Consider changing their names to be unique or compiling them separately. This may become a hard error in the future; see <rust-lang/cargo#6313>. ``` ## Solution I renamed example `change_detection` to `component_change_detection`
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
# Objective Noticed a warning when running tests: ``` > cargo test --workspace warning: output filename collision. The example target `change_detection` in package `bevy_ecs v0.5.0 (/bevy/crates/bevy_ecs)` has the same output filename as the example target `change_detection` in package `bevy v0.5.0 (/bevy)`. Colliding filename is: /bevy/target/debug/examples/change_detection The targets should have unique names. Consider changing their names to be unique or compiling them separately. This may become a hard error in the future; see <rust-lang/cargo#6313>. warning: output filename collision. The example target `change_detection` in package `bevy_ecs v0.5.0 (/bevy/crates/bevy_ecs)` has the same output filename as the example target `change_detection` in package `bevy v0.5.0 (/bevy)`. Colliding filename is: /bevy/target/debug/examples/change_detection.dSYM The targets should have unique names. Consider changing their names to be unique or compiling them separately. This may become a hard error in the future; see <rust-lang/cargo#6313>. ``` ## Solution I renamed example `change_detection` to `component_change_detection`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Noticed a warning when running tests:
Solution
I renamed example
change_detectiontocomponent_change_detection