Skip to content

bevy_asset: don't expect large error in wasm#24192

Merged
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
mockersf:bevy_asset-expected-error-wasm
May 8, 2026
Merged

bevy_asset: don't expect large error in wasm#24192
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
mockersf:bevy_asset-expected-error-wasm

Conversation

@mockersf
Copy link
Copy Markdown
Member

@mockersf mockersf commented May 8, 2026

Objective

  • cargo clippy --target wasm32-unknown-unknown -p bevy_asset --no-deps -- -D warnings
  • clippy::result_large_err is not triggered in wasm
  • ErasedLoadedAsset is not too big in wasm 🤷

Solution

  • gate the expect

Testing

  • CI

@mockersf mockersf added this to the 0.19 milestone May 8, 2026
@mockersf mockersf added A-Assets Load files from disk to use for things like images, models, and sounds C-Code-Quality A section of code that is hard to understand or change labels May 8, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Assets May 8, 2026
@Zeophlite Zeophlite added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels May 8, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 8, 2026
Merged via the queue into bevyengine:main with commit c50521c May 8, 2026
47 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Assets May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants