impl Default for Outline#24196
Merged
Merged
Conversation
…ode aren't visible unless set an explicit width. Generally, if you don't want `Outline`s to be visible you either set their `color` to `Color::NONE` or remove the `Outline` component completely. `Outline`s are often used during debugging, and it's very easy to leave the width unset and convince yourself the missing outline is because of a bug. This PR removes the `Default` derive, and adds an explicit `impl Default` with the width set to 1 pixel.
ickshonpe
added
D-Trivial
ickshonpe
added
S-Needs-Review
mockersf
approved these changes
May 8, 2026
Zeophlite
approved these changes
May 8, 2026
ickshonpe
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
OutlinederivesDefaultwhich means that outlines added to a UI node aren't visible unless you set an explicit width. Generally, if you don't wantOutlines to be visible it's better to either set theircolortoColor::NONEor remove theOutlinecomponent completely, not change the width.Outlines are often used during debugging, and it's very easy to leave the width unset and convince yourself the missing outline is due to a bug.Solution
Remove the
Defaultderive, and add an explicitimpl Defaultwithwidthset toVal::Px(1.).