Store previous_asset in PrepareNextFrameAssets.#24205
Open
larsraph wants to merge 1 commit into
Open
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In
prepare_assetstheprevious_assetis passed toA::prepare_assethowever when an asset is enqueued into thePrepareNextFrameAssetsit's previous asset is removed fromRenderAssetsand dropped. When consuming the queue is attempts to read the value from theRenderAssetswhich always returnsNone.Solution
This change simply stores the previous_asset in the
PrepareNextFrameAssetsqueue.Alternative Solution
I find it dubious that the
RenderAssethas to be removed fromRenderAssetsin the first place. The reason given is that "we remove previous here to ensure that if we are updating the asset then any users will not see the old asset after a new asset is extracted, even if the new asset is not yet ready or we are out of bytes to write." However, I would personally expect to keep stale data until the updated data arrives. If we do that then there would be no need to store the previous asset.Testing