Add texture load hook to gltf extension handler#24207
Draft
beicause wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #21185
Solution
Add
on_texture_loadhook to GltfExtensionHandler. After parsing gltf textures, we iterate gltf extention handlers to let them load the parsed textures to image handles. Gltf extention handlers can choose to bypass it or load it. Once a extention handler loads it we use its result and skip the remaining handlers.I removed the loading textures with
IoTaskPoolbecause we can't - at least&mut LoadContextcannot be accessed from multiple threads. But this probably doesn't matter becauseload_context.load_builder().load()is already deferred load and multi-threaded. This might only be helpful for loading embedded images.Also add
HdrTextureLoaderandExrTextureLoaderfor loading external gltf textures by recognizing file extension. But this is not ideal since asset loader cannot recognize paths or attempt to load and recognize assets.Testing
TODO