clamp time delta by max_delta even when relative speed is greater than 1#24237
Open
mockersf wants to merge 2 commits into
Open
clamp time delta by max_delta even when relative speed is greater than 1#24237mockersf wants to merge 2 commits into
mockersf wants to merge 2 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Diddykonga
reviewed
May 10, 2026
Diddykonga
approved these changes
May 10, 2026
kfc35
added
D-Straightforward
kfc35
approved these changes
May 13, 2026
| @@ -237,26 +237,26 @@ impl Time<Virtual> { | |||
| /// Updates the elapsed duration of `self` by `raw_delta`, up to the `max_delta`. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| /// Updates the elapsed duration of `self` by `raw_delta`, up to the `max_delta`. | |
| /// Updates the elapsed duration of `self` by `raw_delta` * `relative_speed`, up to the `max_delta`. |
| } else { | ||
| scaled | ||
| }; | ||
| self.context_mut().effective_speed = effective_speed; |
Contributor
There was a problem hiding this comment.
If the delta ended up being clamped, should the effective_speed in that case be updated to the value of max_delta / raw_delta? Since effective_speed is supposed to represent the multiplier that was applied to the raw_delta
Contributor
|
Sorry I meant to just comment, not approve just yet 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy/crates/bevy_time/src/virt.rs
Lines 102 to 104 in 2002a18
Solution
Testing