Configurable camera color target size and format#24280
Open
beicause wants to merge 11 commits into
Open
Conversation
Contributor
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Remake #22637. Fixes #21530. This makes texture size, format and whether the main texture is shared by multiple cameras configurable.
Solution
MainPassResolutionOverrideshould be still supported.ColorTarget(which is a subset of texture descriptor) they use (which can point to itself). EachColorTargetwill be extracted and produce aColorTargetTexturesforViewTargetCameraColorTargetfor compatibility with existingMsaaandHdrand allows the size to be set with a factor relative to the viewport size.ExtractedCamera/ExtractedViewto a newViewTargetInfocomponet.What this PR doesn't include and can be follow-ups:
Hdrinto two: one for settingRgba16Floatfor some rendering features and one for controlling tonemap in shader or tonemap in post-processing.Testing
Tested
split_screen,bloom_3dwith someCameraColorTargetsettings.Showcase
anti_aliasingexample now has a resolution settings:Details
Generally only 3D content should be scaled and UI shouldn't be affected but currently users may be able to render the UI to a fixed-resolution texture themselves.