Skip to content

Re-export everything from the gltf library#24321

Open
musjj wants to merge 1 commit into
bevyengine:mainfrom
musjj:gltf-reexport
Open

Re-export everything from the gltf library#24321
musjj wants to merge 1 commit into
bevyengine:mainfrom
musjj:gltf-reexport

Conversation

@musjj
Copy link
Copy Markdown
Contributor

@musjj musjj commented May 16, 2026

Objective

Some traits like GltfExtensionHandler depends on items that weren't re-exported from the gltf library, such as gltf::Node:

fn on_gltf_node(
&mut self,
load_context: &mut LoadContext<'_>,
gltf_node: &Node,
entity: &mut EntityWorldMut,
) {

This means that users won't be able to implement this trait method without manually adding gltf to their dependencies (while also making sure that the version matches up).

Solution

We could just add Node to the re-export, but I think it's safer and more future-proof to just re-export everything. Since they're namespaced under gltf, there's no risk of collisions there.

Testing

  • Did you test these changes? If so, how?

    $ cargo test -p ci
  • Are there any parts that need more testing?

    I don't think so!

  • How can other people (reviewers) test your changes? Is there anything specific they need to know?

    It's just an additional set of re-exports, so if it compiles it's probably fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant