Re-export everything from the gltf library#24321
Open
musjj wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Some traits like
GltfExtensionHandlerdepends on items that weren't re-exported from thegltflibrary, such asgltf::Node:bevy/crates/bevy_gltf/src/loader/extensions/mod.rs
Lines 227 to 232 in fc29274
This means that users won't be able to implement this trait method without manually adding
gltfto their dependencies (while also making sure that the version matches up).Solution
We could just add
Nodeto the re-export, but I think it's safer and more future-proof to just re-export everything. Since they're namespaced undergltf, there's no risk of collisions there.Testing
Did you test these changes? If so, how?
$ cargo test -p ciAre there any parts that need more testing?
I don't think so!
How can other people (reviewers) test your changes? Is there anything specific they need to know?
It's just an additional set of re-exports, so if it compiles it's probably fine.