Skip to content

Include libdisplay-info1 in update-caches#24329

Merged
mockersf merged 2 commits into
bevyengine:mainfrom
amtep:libdisplay-info
May 17, 2026
Merged

Include libdisplay-info1 in update-caches#24329
mockersf merged 2 commits into
bevyengine:mainfrom
amtep:libdisplay-info

Conversation

@amtep
Copy link
Copy Markdown
Contributor

@amtep amtep commented May 17, 2026

Objective

Unbreak linux example tests in merge queue.
Currently run-examples-linux-vulkan is failing.

Solution

At least part of the failure is that it can't find libdisplay-info.so.1.
Include the package that provides it in the cached packages.

Testing

Unfortunately none. I can't reproduce the github environment at home.
We won't see whether this worked until the day after this PR is merged
and the caches get updated again.

amtep added 2 commits May 17, 2026 17:49
It's a dependency of `mesa-vulkan-drivers` so it
should be cached and restored along with it.
@amtep
Copy link
Copy Markdown
Contributor Author

amtep commented May 17, 2026

@mockersf

Copy link
Copy Markdown
Contributor

@NicoZweifel NicoZweifel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'd say we give it a try by running run-examples-linux-vulkan

I managed to reproduce it locally now:

Image

@NicoZweifel
Copy link
Copy Markdown
Contributor

NicoZweifel commented May 17, 2026

Unfortunately none. I can't reproduce the github environment at home.
We won't see whether this worked until the day after this PR is merged
and the caches get updated again.

can confirm that the fix is working in the dockerfile that I used to reproduce:

image
FROM ubuntu:24.04

ENV DEBIAN_FRONTEND=noninteractive
ENV CARGO_HOME=/usr/local/cargo
ENV RUSTUP_HOME=/usr/local/rustup
ENV PATH="/usr/local/cargo/bin:${PATH}"

# Dependencies and Rust
RUN apt-get update && apt-get install -y --no-install-recommends \
   curl ca-certificates software-properties-common pkg-config g++ clang lld git \
   libasound2-dev libudev-dev libwayland-dev libxkbcommon-x11-0 xvfb libxcb-xfixes0-dev \
   libxcursor1 libxi6 libxrandr2 \
   && curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain stable

# Simulate 'update-caches.yml'
# Remove 'libdisplay-info1' from the loop below and rebuild to reproduce the bug
RUN add-apt-repository ppa:kisak/turtle -y && apt-get update -y -qq \
   && apt-get install --no-install-recommends -yq libgl1-mesa-dri mesa-vulkan-drivers \
   && rm -rf ~/apt-cache && mkdir ~/apt-cache \
   && for package in libdisplay-info1 libgbm1 libgl1-mesa-dri libglx-mesa0 mesa-libgallium mesa-vulkan-drivers; do \
        dpkg -L $package | while IFS= read -r f; do if test -f "$f"; then echo "$f"; fi; done | xargs -d '\n' cp --parents --target-directory ~/apt-cache/; \
      done

# Simulate fresh 'example-run.yml'
RUN dpkg --remove --force-depends libgl1-mesa-dri mesa-vulkan-drivers libdisplay-info1

# Restore cache
RUN cp --verbose --force --recursive ~/apt-cache/* /

WORKDIR /app
COPY . .

# Run
CMD xvfb-run cargo run --example ambiguity_detection --features "bevy_ci_testing,trace,trace_chrome,bevy_ui_debug,area_light_luts"

docker build -t bevy-repro .
docker run --rm bevy-repro

Copy link
Copy Markdown
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed working in ci on another repo

@mockersf mockersf added this pull request to the merge queue May 17, 2026
Merged via the queue into bevyengine:main with commit b175e34 May 17, 2026
38 checks passed
@amtep amtep deleted the libdisplay-info branch May 17, 2026 17:03
mockersf pushed a commit to mockersf/bevy that referenced this pull request May 21, 2026
# Objective

Unbreak linux example tests in merge queue.
Currently `run-examples-linux-vulkan` is failing.

## Solution

At least part of the failure is that it can't find
`libdisplay-info.so.1`.
Include the package that provides it in the cached packages.

## Testing

Unfortunately none. I can't reproduce the github environment at home.
We won't see whether this worked until the day after this PR is merged
and the caches get updated again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants