Reapply GPU-driven HLOD evaluation, using the new HLOD view origin.#24343
Merged
alice-i-cecile merged 2 commits intoMay 19, 2026
Conversation
…oCpuCulling` is specified. (bevyengine#23115) (bevyengine#24252) This reverts commit dc3a6cb.
This makes GPU-driven visibility range evaluation use the same semantics, introduced in bevyengine#24289, as CPU-driven visibility range evaluation. To test, run the `visibility_range` example with `--no-cpu-culling`, and use the WASD keys to move behind the flight helmet and zoom out, while closely watching the shadow. Note that the shadow now properly reflects the LOD of the model.
pcwalton
added
C-Feature
Zeophlite
approved these changes
May 18, 2026
kfc35
approved these changes
May 18, 2026
kfc35
added
the
S-Ready-For-Final-Review
mockersf
pushed a commit
to mockersf/bevy
that referenced
this pull request
May 21, 2026
…evyengine#24343) This PR undoes the revert of bevyengine#23115 that was done in bevyengine#24252. As part of doing so, it makes GPU-driven visibility range evaluation use the same semantics, introduced in bevyengine#24289, as CPU-driven visibility range evaluation. The first commit in this PR is the un-revert, and the second commit is the change to use the new machinery bevyengine#24289. This means that you can simply review the second commit (which is very short). To test, run the `visibility_range` example with `--no-cpu-culling`, and use the WASD keys to move behind the flight helmet and zoom out, while closely watching the shadow. Note that the shadow now properly reflects the LOD of the model.
mockersf
pushed a commit
that referenced
this pull request
May 21, 2026
…24343) This PR undoes the revert of #23115 that was done in #24252. As part of doing so, it makes GPU-driven visibility range evaluation use the same semantics, introduced in #24289, as CPU-driven visibility range evaluation. The first commit in this PR is the un-revert, and the second commit is the change to use the new machinery #24289. This means that you can simply review the second commit (which is very short). To test, run the `visibility_range` example with `--no-cpu-culling`, and use the WASD keys to move behind the flight helmet and zoom out, while closely watching the shadow. Note that the shadow now properly reflects the LOD of the model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR undoes the revert of #23115 that was done in #24252. As part of doing so, it makes GPU-driven visibility range evaluation use the same semantics, introduced in #24289, as CPU-driven visibility range evaluation.
The first commit in this PR is the un-revert, and the second commit is the change to use the new machinery #24289. This means that you can simply review the second commit (which is very short).
To test, run the
visibility_rangeexample with--no-cpu-culling, and use the WASD keys to move behind the flight helmet and zoom out, while closely watching the shadow. Note that the shadow now properly reflects the LOD of the model.