Fix rounding in the pixel_grid_snap example#24358
Merged
mockersf merged 1 commit intoMay 21, 2026
Merged
Conversation
Signed-off-by: Ethan Uppal <113849268+ethanuppal@users.noreply.github.com>
ethanuppal
changed the title
pixel_grid_snap examplepixel_grid_snap example
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
kfc35
added
C-Examples
kfc35
approved these changes
May 20, 2026
kfc35
added
S-Ready-For-Final-Review
mockersf
approved these changes
May 21, 2026
ncthbrt
approved these changes
May 21, 2026
ncthbrt
left a comment
ncthbrt
left a comment
There was a problem hiding this comment.
LGTM. Makes sense and small, non-invasive change
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #24350
Solution
I replaced
roundwithflooras mentioned in the issue.Testing
I ran the program on my computer and observed the change.
Perhaps other display sizes need testing, but theoretically the math should be correct. This is my first PR, so I might have missed something.
Compare the clipping on window sizes that are a multiple of the canvas's resolution to those that are not.
I tested on macOS; I cannot test on any other platform.
Showcase
Click to view showcase