Allow bsn caching syntax for zero-argument function calls#24443
Open
laundmo wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
In #24367 the caching syntax using the
:prefix was limited to only being allowed in front of scene functions without arguments. The way this check was implemented meant the following was not valid::scene()even tho:sceneis converted toscene()in the macro anyways. Theres an argument for disallowing()call syntax from the start, to make it obvious whats going on, but at least when working in the context of the Rust macro, a function name being converted to a function call seems unintuitive.Solution
Change the check used to allow zero-argument
:scene()calls as well as:sceneauto-called functions.Testing
cargo test --lib bevy_scenecargo run --example feathers_gallery --features=bevy_feathers