[Merged by Bors] - CI tool usage by mockersf · Pull Request #3876 · bevyengine/bevy

mockersf · 2022-02-06T14:28:51Z

Objective

Original objective was to add doc build warning check to the ci local execution
I somewhat deviated and changed other things...

Solution

cargo run -p ci can now take more parameters:

format - cargo fmt
clippy - clippy
compile-fail - bevy_ecs_compile_fail_tests tests
test - tests but not doc tests and do not build examples
doc-test - doc tests
doc-check - doc build and warnings
bench-check - check that benches build
example-check - check that examples build
lints - group - run lints and format and clippy
doc - group - run doc-test and doc-check
compile - group - run compile-fail and bench-check and example-check
not providing a parameter will run everything

Ci is using those when possible:

build jobs now don't run doc tests and don't build examples. it makes this job faster, but doc tests and examples are not built for each architecture target
ci job doesn't run the compile-fail part but only format and clippy, taking less time
check-benches becomes check-compiles and runs the compile tasks. It takes longer. I also fixed how it was using cache
check-doc job is now independent and also run the doc tests, so it takes longer. I commented out the deadlinks check as it takes 2.5 minutes (to install) and doesn't work

shanesveller · 2022-02-07T13:52:43Z

Mentioning it as possibly topical, given the plethora of crate feature flags in the Bevy family:

https://github.com/taiki-e/cargo-hack

I've found this helpful in my work to make sure that any/all combos of crate features continue to build without warnings or failures. I'm leaning on --each-feature and --feature-powerset

At the scope of something like Bevy it's probably prohibitive to run in CI, though. It's only practical for me by tolerating bloat of /target locally and using cargo-sweep whenever it gets too bad.

mockersf · 2022-02-09T01:36:20Z

https://github.com/taiki-e/cargo-hack

It could be interesting to add a weekly workflow to check feature flag combinations, but that's going to be too much to do on each commit 👍

alice-i-cecile

Very nice. I like this direction, and the changes look good.

alice-i-cecile · 2022-04-22T06:25:55Z

@mockersf is this ready to go? I remember liking this quite a bit.

alice-i-cecile · 2022-04-22T06:26:00Z

bors try

bors · 2022-04-22T06:26:03Z

try

Merge conflict.

alice-i-cecile · 2022-05-02T12:16:21Z

bors r+

# Objective - Original objective was to add doc build warning check to the ci local execution - I somewhat deviated and changed other things... ## Solution `cargo run -p ci` can now take more parameters: * `format` - cargo fmt * `clippy` - clippy * `compile-fail` - bevy_ecs_compile_fail_tests tests * `test` - tests but not doc tests and do not build examples * `doc-test` - doc tests * `doc-check` - doc build and warnings * `bench-check` - check that benches build * `example-check` - check that examples build * `lints` - group - run lints and format and clippy * `doc` - group - run doc-test and doc-check * `compile` - group - run compile-fail and bench-check and example-check * not providing a parameter will run everything Ci is using those when possible: * `build` jobs now don't run doc tests and don't build examples. it makes this job faster, but doc tests and examples are not built for each architecture target * `ci` job doesn't run the `compile-fail` part but only format and clippy, taking less time * `check-benches` becomes `check-compiles` and runs the `compile` tasks. It takes longer. I also fixed how it was using cache * `check-doc` job is now independent and also run the doc tests, so it takes longer. I commented out the deadlinks check as it takes 2.5 minutes (to install) and doesn't work

bors · 2022-05-02T12:21:51Z

This PR was included in a batch that was canceled, it will be automatically retried

# Objective - Original objective was to add doc build warning check to the ci local execution - I somewhat deviated and changed other things... ## Solution `cargo run -p ci` can now take more parameters: * `format` - cargo fmt * `clippy` - clippy * `compile-fail` - bevy_ecs_compile_fail_tests tests * `test` - tests but not doc tests and do not build examples * `doc-test` - doc tests * `doc-check` - doc build and warnings * `bench-check` - check that benches build * `example-check` - check that examples build * `lints` - group - run lints and format and clippy * `doc` - group - run doc-test and doc-check * `compile` - group - run compile-fail and bench-check and example-check * not providing a parameter will run everything Ci is using those when possible: * `build` jobs now don't run doc tests and don't build examples. it makes this job faster, but doc tests and examples are not built for each architecture target * `ci` job doesn't run the `compile-fail` part but only format and clippy, taking less time * `check-benches` becomes `check-compiles` and runs the `compile` tasks. It takes longer. I also fixed how it was using cache * `check-doc` job is now independent and also run the doc tests, so it takes longer. I commented out the deadlinks check as it takes 2.5 minutes (to install) and doesn't work

bors · 2022-05-02T12:41:27Z

Build failed (retrying...):

build (stable, macos-latest)

# Objective - Original objective was to add doc build warning check to the ci local execution - I somewhat deviated and changed other things... ## Solution `cargo run -p ci` can now take more parameters: * `format` - cargo fmt * `clippy` - clippy * `compile-fail` - bevy_ecs_compile_fail_tests tests * `test` - tests but not doc tests and do not build examples * `doc-test` - doc tests * `doc-check` - doc build and warnings * `bench-check` - check that benches build * `example-check` - check that examples build * `lints` - group - run lints and format and clippy * `doc` - group - run doc-test and doc-check * `compile` - group - run compile-fail and bench-check and example-check * not providing a parameter will run everything Ci is using those when possible: * `build` jobs now don't run doc tests and don't build examples. it makes this job faster, but doc tests and examples are not built for each architecture target * `ci` job doesn't run the `compile-fail` part but only format and clippy, taking less time * `check-benches` becomes `check-compiles` and runs the `compile` tasks. It takes longer. I also fixed how it was using cache * `check-doc` job is now independent and also run the doc tests, so it takes longer. I commented out the deadlinks check as it takes 2.5 minutes (to install) and doesn't work

bors · 2022-05-02T14:55:24Z

This PR was included in a batch that was canceled, it will be automatically retried

# Objective - Original objective was to add doc build warning check to the ci local execution - I somewhat deviated and changed other things... ## Solution `cargo run -p ci` can now take more parameters: * `format` - cargo fmt * `clippy` - clippy * `compile-fail` - bevy_ecs_compile_fail_tests tests * `test` - tests but not doc tests and do not build examples * `doc-test` - doc tests * `doc-check` - doc build and warnings * `bench-check` - check that benches build * `example-check` - check that examples build * `lints` - group - run lints and format and clippy * `doc` - group - run doc-test and doc-check * `compile` - group - run compile-fail and bench-check and example-check * not providing a parameter will run everything Ci is using those when possible: * `build` jobs now don't run doc tests and don't build examples. it makes this job faster, but doc tests and examples are not built for each architecture target * `ci` job doesn't run the `compile-fail` part but only format and clippy, taking less time * `check-benches` becomes `check-compiles` and runs the `compile` tasks. It takes longer. I also fixed how it was using cache * `check-doc` job is now independent and also run the doc tests, so it takes longer. I commented out the deadlinks check as it takes 2.5 minutes (to install) and doesn't work

bors · 2022-05-02T16:04:42Z

This PR was included in a batch that timed out, it will be automatically retried

# Objective - Original objective was to add doc build warning check to the ci local execution - I somewhat deviated and changed other things... ## Solution `cargo run -p ci` can now take more parameters: * `format` - cargo fmt * `clippy` - clippy * `compile-fail` - bevy_ecs_compile_fail_tests tests * `test` - tests but not doc tests and do not build examples * `doc-test` - doc tests * `doc-check` - doc build and warnings * `bench-check` - check that benches build * `example-check` - check that examples build * `lints` - group - run lints and format and clippy * `doc` - group - run doc-test and doc-check * `compile` - group - run compile-fail and bench-check and example-check * not providing a parameter will run everything Ci is using those when possible: * `build` jobs now don't run doc tests and don't build examples. it makes this job faster, but doc tests and examples are not built for each architecture target * `ci` job doesn't run the `compile-fail` part but only format and clippy, taking less time * `check-benches` becomes `check-compiles` and runs the `compile` tasks. It takes longer. I also fixed how it was using cache * `check-doc` job is now independent and also run the doc tests, so it takes longer. I commented out the deadlinks check as it takes 2.5 minutes (to install) and doesn't work

bors · 2022-05-02T18:04:33Z

This PR was included in a batch that timed out, it will be automatically retried

mockersf · 2022-05-02T18:08:52Z

bors r-

bors · 2022-05-02T18:08:54Z

Canceled.

mockersf · 2022-05-02T18:09:01Z

this one is causing bors timeout

mockersf · 2022-05-02T18:11:54Z

should be fixed now 👍

alice-i-cecile · 2022-05-02T18:37:38Z

bors retry

alice-i-cecile · 2022-05-02T19:13:16Z

bors r+

# Objective - Original objective was to add doc build warning check to the ci local execution - I somewhat deviated and changed other things... ## Solution `cargo run -p ci` can now take more parameters: * `format` - cargo fmt * `clippy` - clippy * `compile-fail` - bevy_ecs_compile_fail_tests tests * `test` - tests but not doc tests and do not build examples * `doc-test` - doc tests * `doc-check` - doc build and warnings * `bench-check` - check that benches build * `example-check` - check that examples build * `lints` - group - run lints and format and clippy * `doc` - group - run doc-test and doc-check * `compile` - group - run compile-fail and bench-check and example-check * not providing a parameter will run everything Ci is using those when possible: * `build` jobs now don't run doc tests and don't build examples. it makes this job faster, but doc tests and examples are not built for each architecture target * `ci` job doesn't run the `compile-fail` part but only format and clippy, taking less time * `check-benches` becomes `check-compiles` and runs the `compile` tasks. It takes longer. I also fixed how it was using cache * `check-doc` job is now independent and also run the doc tests, so it takes longer. I commented out the deadlinks check as it takes 2.5 minutes (to install) and doesn't work

bors · 2022-05-02T19:29:41Z

Pull request successfully merged into main.

Build succeeded:

# Objective - Original objective was to add doc build warning check to the ci local execution - I somewhat deviated and changed other things... ## Solution `cargo run -p ci` can now take more parameters: * `format` - cargo fmt * `clippy` - clippy * `compile-fail` - bevy_ecs_compile_fail_tests tests * `test` - tests but not doc tests and do not build examples * `doc-test` - doc tests * `doc-check` - doc build and warnings * `bench-check` - check that benches build * `example-check` - check that examples build * `lints` - group - run lints and format and clippy * `doc` - group - run doc-test and doc-check * `compile` - group - run compile-fail and bench-check and example-check * not providing a parameter will run everything Ci is using those when possible: * `build` jobs now don't run doc tests and don't build examples. it makes this job faster, but doc tests and examples are not built for each architecture target * `ci` job doesn't run the `compile-fail` part but only format and clippy, taking less time * `check-benches` becomes `check-compiles` and runs the `compile` tasks. It takes longer. I also fixed how it was using cache * `check-doc` job is now independent and also run the doc tests, so it takes longer. I commented out the deadlinks check as it takes 2.5 minutes (to install) and doesn't work

github-actions Bot added the S-Needs-Triage This issue needs to be labelled label Feb 6, 2022

mockersf added A-Build-System Related to build systems or continuous integration and removed S-Needs-Triage This issue needs to be labelled labels Feb 6, 2022

IceSentry approved these changes Feb 7, 2022

View reviewed changes

Comment thread tools/ci/src/main.rs Outdated

IceSentry reviewed Feb 7, 2022

View reviewed changes

Comment thread .github/workflows/ci.yml

MinerSebas reviewed Feb 9, 2022

View reviewed changes

Comment thread tools/ci/src/main.rs Outdated

Comment thread tools/ci/src/main.rs

Comment thread tools/ci/src/main.rs Outdated

alice-i-cecile approved these changes Feb 12, 2022

View reviewed changes

alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 12, 2022

mockersf added 11 commits April 27, 2022 13:20

add building docs to local run of ci package

0425778

update ci crate to run tasks behind flags

7874138

more use of ci package in CI

fad6fd6

update contributing doc

6a2aa4e

remove cargo deadlinks for now as it doesn't work and takes some time

4d385cf

some paths and caches improvements

b310572

trying a few speedup for doc

2b7eb43

typo in doc and link

7e8e4ba

remove commented command

7ca86db

explain commented ci steps

5a5bdad

fix comments and arg order

d657063

mockersf force-pushed the local-ci-check-doc-warnings branch from 26d8341 to d657063 Compare April 27, 2022 11:21

rename job for bors

e1e25d0

bors Bot changed the title ~~CI tool usage~~ [Merged by Bors] - CI tool usage May 2, 2022

bors Bot closed this May 2, 2022

OniriqueCherry mentioned this pull request May 11, 2026

Don't leave root during bench-check. #24248

Open

Uh oh!

Conversation

mockersf commented Feb 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Objective

Solution

Uh oh!

shanesveller commented Feb 7, 2022

Uh oh!

Uh oh!

Uh oh!

mockersf commented Feb 9, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alice-i-cecile left a comment

Choose a reason for hiding this comment

Uh oh!

alice-i-cecile commented Apr 22, 2022

Uh oh!

alice-i-cecile commented Apr 22, 2022

Uh oh!

bors Bot commented Apr 22, 2022

try

Uh oh!

alice-i-cecile commented May 2, 2022

Uh oh!

bors Bot commented May 2, 2022

Uh oh!

bors Bot commented May 2, 2022

Uh oh!

bors Bot commented May 2, 2022

Uh oh!

bors Bot commented May 2, 2022

Uh oh!

bors Bot commented May 2, 2022

Uh oh!

mockersf commented May 2, 2022

Uh oh!

bors Bot commented May 2, 2022

Uh oh!

mockersf commented May 2, 2022

Uh oh!

mockersf commented May 2, 2022

Uh oh!

alice-i-cecile commented May 2, 2022

Uh oh!

alice-i-cecile commented May 2, 2022

Uh oh!

bors Bot commented May 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mockersf commented Feb 6, 2022 •

edited

Loading