Improve comment in extract_windows system about main thread window handling#5071
Closed
alice-i-cecile wants to merge 2 commits intobevyengine:mainfrom
Closed
Improve comment in extract_windows system about main thread window handling#5071alice-i-cecile wants to merge 2 commits intobevyengine:mainfrom
alice-i-cecile wants to merge 2 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-Rendering
Member
Author
|
bors try |
Contributor
tryBuild failed: |
DJMcNab
reviewed
Jun 22, 2022
Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
alice-i-cecile
changed the title
alice-i-cecile
changed the title
DJMcNab
approved these changes
Jun 22, 2022
Member
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
I mean sure, I guess.
I'd be just as happy to close this out, since this is already a few lines above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful to give some indication that the _marker parameter cannot be safely removed.