Use CoreUtils::getPostMetaKeys to get all keys for removal #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklhtv
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the removal of BeyondWords metadata from posts to make it more maintainable and robust. The main change is to use a centralized method for retrieving all relevant metadata keys, instead of hardcoding them. Additionally, a new unit test ensures this removal process works correctly and does not affect unrelated metadata.
Refactoring and maintainability:
PostMetaUtils::removeAllBeyondwordsMetadatato useCoreUtils::getPostMetaKeys('all')for retrieving all BeyondWords-related post meta keys, replacing the previous hardcoded list. This change makes it easier to update supported keys in the future and reduces the risk of missing keys.Testing improvements:
removeAllBeyondwordsMetadata) to verify that all BeyondWords keys are removed from a post while unrelated custom meta keys remain untouched. This test increases confidence in the correctness of the metadata removal logic.CoreUtilsin the test file to support the new test.