Validation for some publicode.yml files takes longer than expected.

[adrian-lorenc]

I have disabled remote existence checks for URLs, but in some cases it still takes a considerable amount of time.

Cases:
https://gitlab.opencode.de/ig-bvc/standard-images/grund-images/centos/-/raw/main/publiccode.yml
https://gitlab.opencode.de/ig-bvc/standard-images/grund-images/alpine/-/raw/main/publiccode.yml
https://gitlab.opencode.de/ig-bvc/ag-sig/cosign-admissioncontroller-tests/-/raw/main/publiccode.yml

Perhaps we could extend the ParserConfig and provide a configurable timeout setting.

[bfabio]

Looks like this is due to the logo that is never served and it just hangs on request:

❯ time curl https://gitlab.o4oe.de/uploads/-/system/group/avatar/101/87377279.png
curl: (28) Connection timed out after 300686 milliseconds

real	5m0,697s
user	0m0,011s
sys	0m0,024s

The parser times out as well, depending on how the default kernel TCP timeout is configured.

❯ time publiccode-parser https://gitlab.opencode.de/ig-bvc/standard-images/grund-images/centos/-/raw/main/publiccode.yml
publiccode.yml:5:1: warning: publiccodeYmlVersion: v0.2 is not the latest version, use '0'. Parsing this file as v0.5.
publiccode.yml:51:5: error: description.it.features: features must contain more than 0 items
publiccode.yml:73:5: error: description.de.features: features must contain more than 0 items
publiccode.yml:7:1: error: url: 'https://gitlab.o4oe.de/ig-bvc/standard-images/grund-images/centos' not reachable: HTTP GET failed for https://gitlab.o4oe.de/ig-bvc/standard-images/grund-images/centos: Get "https://gitlab.o4oe.de/ig-bvc/standard-images/grund-images/centos": dial tcp 10.200.5.115:443: i/o timeout
publiccode.yml:7:1: error: url: is not a valid code repository
publiccode.yml:10:1: error: logo: HTTP GET failed for https://gitlab.o4oe.de/uploads/-/system/group/avatar/101/87377279.png: Get "https://gitlab.o4oe.de/uploads/-/system/group/avatar/101/87377279.png": dial tcp 10.200.5.125:443: i/o timeout
publiccode.yml:32:3: warning: legal.repoOwner: This key is DEPRECATED and will be removed in the future. Use 'organisation.name' instead
publiccode.yml:51:5: warning: description.it.genericName: This key is DEPRECATED and will be removed in the future. It's safe to drop it
publiccode.yml:73:5: warning: description.de.genericName: This key is DEPRECATED and will be removed in the future. It's safe to drop it
publiccode.yml:38:1: warning: it: Lowercase country codes are DEPRECATED and will be removed in the future. Use 'IT' instead
publiccode.yml:0:0: warning: IT.conforme: This key is DEPRECATED and will be removed in the future. It's safe to drop it
publiccode.yml:0:0: warning: IT.riuso.codiceIPA: This key is DEPRECATED and will be removed in the future. Use 'organisation.uri' and set it to 'urn:x-italian-pa:agid' instead

real	3m3,554s
user	0m0,105s
sys	0m0,057s

A configurable timeout is a good idea, even if it won't help in this case.

[bfabio]

There was actually an issue that made the parser use the network even when DisableNetwork was set: italia/publiccode-parser-go#289

It is now fixed in https://github.com/italia/publiccode-parser-go/releases/tag/v5.2.3.

[bfabio]

@adrian-lorenc fixed in v1.1.1