Skip to content

xPtankPool: implement several ptank functions#542

Merged
JoshSanch merged 2 commits intobfbbdecomp:mainfrom
velkog:main
May 15, 2025
Merged

xPtankPool: implement several ptank functions#542
JoshSanch merged 2 commits intobfbbdecomp:mainfrom
velkog:main

Conversation

@velkog
Copy link
Contributor

@velkog velkog commented May 15, 2025

Implement sort_buckets, create_ptank, destroy_ptank, render_ptank, compare_ptanks, andxPTankPoolRender

All fully matching except for create_ptank, which is having mismatches with float assignments.

…er_ptank, compare_ptanks, andxPTankPoolRender

All fully matching except for create_ptank, which is having mismatches with float assignments.
@github-actions
Copy link

🆗 ✅

+1108 bytes
🆗 Bot Rating: A fantastic contribution! ✨🎉

No Regressions 🎉

Progress: 9

📈 main/SB/Core/x/xPtankPool - .text +1040 bytes -> 39.28%
main/SB/Core/x/xPtankPool - .data +56 bytes -> 100.00%
📈 main/SB/Core/x/xPtankPool - .sdata2 +12 bytes -> 50.00%
main/SB/Core/x/xPtankPool - @unnamed@xPtankPool_cpp@::sort_buckets(@unnamed@xPtankPool_cpp@::group_data&) +320 bytes -> 100.00%
main/SB/Core/x/xPtankPool - xPTankPoolRender() +280 bytes -> 100.00%
📈 main/SB/Core/x/xPtankPool - ptank_pool::flush() +24 bytes -> 9.52%
📈 main/SB/Core/x/xPtankPool - @unnamed@xPtankPool_cpp@::create_ptank(unsigned int) +180 bytes -> 86.67%
main/SB/Core/x/xPtankPool - @unnamed@xPtankPool_cpp@::compare_ptanks(const void*, const void*) +148 bytes -> 100.00%
main/SB/Core/x/xPtankPool - @unnamed@xPtankPool_cpp@::destroy_ptank(RpAtomic*) +88 bytes -> 100.00%

Removing this very incomplete implementation, accidentally left in.
@github-actions
Copy link

🆗 ✅

+1084 bytes
🆗 Bot Rating: A fantastic contribution! ✨🎉

No Regressions 🎉

Progress: 8

📈 main/SB/Core/x/xPtankPool - .text +1016 bytes -> 38.38%
main/SB/Core/x/xPtankPool - .data +56 bytes -> 100.00%
📈 main/SB/Core/x/xPtankPool - .sdata2 +12 bytes -> 50.00%
main/SB/Core/x/xPtankPool - @unnamed@xPtankPool_cpp@::sort_buckets(@unnamed@xPtankPool_cpp@::group_data&) +320 bytes -> 100.00%
main/SB/Core/x/xPtankPool - xPTankPoolRender() +280 bytes -> 100.00%
📈 main/SB/Core/x/xPtankPool - @unnamed@xPtankPool_cpp@::create_ptank(unsigned int) +180 bytes -> 86.67%
main/SB/Core/x/xPtankPool - @unnamed@xPtankPool_cpp@::compare_ptanks(const void*, const void*) +148 bytes -> 100.00%
main/SB/Core/x/xPtankPool - @unnamed@xPtankPool_cpp@::destroy_ptank(RpAtomic*) +88 bytes -> 100.00%

@JoshSanch JoshSanch merged commit 5e21a7c into bfbbdecomp:main May 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants