let HDRRULE work with build system too (fix #502)#559
Closed
paolopas wants to merge 3 commits intobfgroup:mainfrom
Closed
let HDRRULE work with build system too (fix #502)#559paolopas wants to merge 3 commits intobfgroup:mainfrom
paolopas wants to merge 3 commits intobfgroup:mainfrom
Conversation
* updated test/core_dependencies.py to check for both mode of interpreter operation, with build system or not (-f option) * backtrace_line with unknown line (only file) now allowed, this is the best we can do in the case of HDRSCAN regex errors * headers cleanup in regexp.cpp, switched to C++ headers and removed unused <stdio.h> and <stdlib.h>; refined regerror for uniform support of on target variables (HDRSCAN) and common rules (i.e. MATCH) * new find_module in modules.h for neutral lookup (never creating a new module on miss record, as bindmodule instead does) * new find_target in rules.h for neutral lookup (never creating a new rule on miss record, as bindrule instead does); commented target_ref and targets_ref types to prevent ambiguities among struct _target(s) and struct b2::target_ref; added a ctor for target_ref with a TARGET * parameter
qualified hdrrule nor global import for the hdrrule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/core_dependencies.pyto check for both mode of interpreter operation, with build system or not (-foption)backtrace_linewith unknown line (only file) now allowed, this is the best we can do in the case ofHDRSCANregex errorsregexp.cpp, switched to C++ headers and removed unused<stdio.h>and<stdlib.h>; refinedregerrorfor uniform support of on target variables (HDRSCAN) and common rules (i.e.MATCH)find_moduleinmodules.hfor neutral lookup (never creating a new module on miss record, asbindmoduleinstead does)find_targetinrules.hfor neutral lookup (never creating a new target on miss record, asbindtargetinstead does); commentedtarget_refandtargets_reftypes to prevent ambiguities amongstruct _target(s) andstruct b2::target_ref; added a ctor fortarget_refwith a TARGET * parameterNote
The changes to
build/scanner.jam(c9563b5) are purely optimizations. This PR is fully backwards compatible with any version of scanner you use.