ui: save gradient checkpointing option by default #2544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves how configuration arguments—especially boolean flags—are handled and saved, ensuring greater clarity and consistency in the training configuration. The main changes focus on making boolean values explicit in argument lists and guaranteeing that certain important fields are always saved, even when defaults would otherwise be omitted.
Improvements to argument handling and configuration saving:
Boolean arguments are now always passed explicitly with their value (e.g.,
--flag=trueor--flag=false), rather than relying on presence/absence, to avoid ambiguity and ensure that argparse defaults are properly overridden (simpletuner/helpers/configuration/loader.py).Introduced an
always_save_fieldsset to specify configuration fields (such asgradient_checkpointing) that must always be saved, regardless of whether their value matches the default, to avoid ambiguity in training runs (simpletuner/simpletuner_sdk/server/services/training_service.py).Updated the logic for pruning default values: fields in
always_save_fieldsare now always saved, even whenpreserve_defaultsis enabled, ensuring critical configuration is never omitted (simpletuner/simpletuner_sdk/server/services/training_service.py).