Skip to content

Conversation

@bghira
Copy link
Owner

@bghira bghira commented Feb 1, 2026

This pull request improves how configuration arguments—especially boolean flags—are handled and saved, ensuring greater clarity and consistency in the training configuration. The main changes focus on making boolean values explicit in argument lists and guaranteeing that certain important fields are always saved, even when defaults would otherwise be omitted.

Improvements to argument handling and configuration saving:

  • Boolean arguments are now always passed explicitly with their value (e.g., --flag=true or --flag=false), rather than relying on presence/absence, to avoid ambiguity and ensure that argparse defaults are properly overridden (simpletuner/helpers/configuration/loader.py).

  • Introduced an always_save_fields set to specify configuration fields (such as gradient_checkpointing) that must always be saved, regardless of whether their value matches the default, to avoid ambiguity in training runs (simpletuner/simpletuner_sdk/server/services/training_service.py).

  • Updated the logic for pruning default values: fields in always_save_fields are now always saved, even when preserve_defaults is enabled, ensuring critical configuration is never omitted (simpletuner/simpletuner_sdk/server/services/training_service.py).

@bghira bghira merged commit a89bcfa into main Feb 1, 2026
2 checks passed
@bghira bghira deleted the bugfix/gradient-checkpointing-not-true branch February 1, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants