Update Container.ts to be more testable#205
Merged
Merged
Conversation
Author
|
Figure if im going to be a contributor to the package, i should at least contribute more than a one line typing change :) |
Owner
|
@jmclean-cnexus this is great! Moving the utility functions into a separate file really helps with reducing complexity. |
bgub
requested changes
Sep 10, 2020
Owner
bgub
left a comment
bgub
left a comment
There was a problem hiding this comment.
Just reviewed with a few quick requested changes. Once those are fixed, I'll build, format, and then merge! Thanks for the great contribution!
bgub
approved these changes
Sep 10, 2020
Owner
|
@jmclean-cnexus perfect! I'll merge and release a new version on npm this evening after I get back from work. Thanks again! 😄 |
Owner
|
@jmclean-cnexus just merged and published as version 8.0.8 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Break out the container.ts code so utility functions are imported, and can be tested in isolation. Added some more unit tests for the low hanging fruit utility functions