Conversation
bguise987
added a commit
that referenced
this pull request
Mar 11, 2026
* Update github username (#39) * Update Python versions (#40) * Update tox.ini for newer file format and new Python versions * Update GitHub Actions workflow to use newer Python versions * Update GitHub Actions versions * Bugfix/fix race condition (#41) * Fix race condition causing intermittent gzip corruption The _process_chunk method checked _last_chunk to determine whether to use Z_FINISH, but _last_chunk wasn't set until after the read thread submitted the final chunk. This caused the last chunk to sometimes be compressed with Z_SYNC_FLUSH instead of Z_FINISH, producing invalid gzip files with unterminated deflate streams (00 00 FF FF marker). Fix by peeking ahead in _read_file to determine is_last before submitting to the pool, and passing the flag directly to _process_chunk. * Update tests to reflect passing in is_last to _process_chunk --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
bguise987
added a commit
that referenced
this pull request
Apr 2, 2026
* Update github username (#39) * Update Python versions (#40) * Update tox.ini for newer file format and new Python versions * Update GitHub Actions workflow to use newer Python versions * Update GitHub Actions versions * Specify GitHub actions Python versions as strings * Bugfix/fix race condition (#41) * Fix race condition causing intermittent gzip corruption The _process_chunk method checked _last_chunk to determine whether to use Z_FINISH, but _last_chunk wasn't set until after the read thread submitted the final chunk. This caused the last chunk to sometimes be compressed with Z_SYNC_FLUSH instead of Z_FINISH, producing invalid gzip files with unterminated deflate streams (00 00 FF FF marker). Fix by peeking ahead in _read_file to determine is_last before submitting to the pool, and passing the flag directly to _process_chunk. * Update tests to reflect passing in is_last to _process_chunk --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * Update how package gets version metadata (#43) * Update how package gets version metadata * Add pyproject.toml * Delete setup.py --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
bguise987
added a commit
that referenced
this pull request
Apr 2, 2026
* Update github username (#39) * Update Python versions (#40) * Update tox.ini for newer file format and new Python versions * Update GitHub Actions workflow to use newer Python versions * Update GitHub Actions versions * Specify GitHub actions Python versions as strings * Bugfix/fix race condition (#41) * Fix race condition causing intermittent gzip corruption The _process_chunk method checked _last_chunk to determine whether to use Z_FINISH, but _last_chunk wasn't set until after the read thread submitted the final chunk. This caused the last chunk to sometimes be compressed with Z_SYNC_FLUSH instead of Z_FINISH, producing invalid gzip files with unterminated deflate streams (00 00 FF FF marker). Fix by peeking ahead in _read_file to determine is_last before submitting to the pool, and passing the flag directly to _process_chunk. * Update tests to reflect passing in is_last to _process_chunk --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * Update how package gets version metadata (#43) * Update how package gets version metadata * Add pyproject.toml * Delete setup.py * Version bump to 2.0.0 --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been awhile!