This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Fix deprecation and call binary name from PATH #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isort Path setting can be an absolute path or the bin name, and would run the bin from your PATH.
Contributor
Author
|
Not in the pull request, but default path could be just "isort". This change makes it possible to open atom from a virtual env and run the venv's isort. |
checkForUnsortedImports() was called as checkImports() in some places. Change name to checkImports() to be more similar to sortImports() and fix calls.
checkForPythonContext was not being called, instead was used as a property. Correctly call as function and also call when “Checking” imports to avoid checking in non python field.
jmfederico
changed the title
Owner
|
Excellent work! Thank you! |
bh
added a commit
that referenced
this pull request
Feb 22, 2015
Fix deprecation and call binary name from PATH
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort Path setting can be an absolute path or the bin name, and would
run the bin from your PATH.