Merged
Conversation
bh2smith
approved these changes
Nov 3, 2024
Owner
bh2smith
left a comment
bh2smith
left a comment
There was a problem hiding this comment.
Looks good pending bytea consideration.
Comment on lines
+38
to
+39
| df = extract_data_from_postgres(env, job) | ||
| return load_data_into_dune(df, env, job) |
Owner
There was a problem hiding this comment.
Only thing missing here is a transformation of bytea columns to 0x prefixed hex strings. And a test for such a type.
Collaborator
Author
There was a problem hiding this comment.
Added that transformation and reflected it in the test fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.