Conversation
mooster531
commented
Nov 12, 2024
bh2smith
approved these changes
Nov 13, 2024
Owner
bh2smith
left a comment
bh2smith
left a comment
There was a problem hiding this comment.
I think this is great!
Would like to encapsulate the decision logic on types into one place that maintains the simplistic readability of the main flow.
Would also like to have an explicit unit test of the function introduced here.
Collaborator
Author
|
Added a test for the decimal parser and cleaned up those Unions. |
Collaborator
Author
|
Integrated |
bh2smith
reviewed
Nov 13, 2024
Co-authored-by: Benjamin Smith <bh2smith@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62