Skip to content
This repository was archived by the owner on Jun 18, 2021. It is now read-only.

Python3 and pip install#30

Merged
bhdouglass merged 5 commits intobhdouglass:masterfrom
delijati:master
Apr 5, 2018
Merged

Python3 and pip install#30
bhdouglass merged 5 commits intobhdouglass:masterfrom
delijati:master

Conversation

@delijati
Copy link
Copy Markdown
Contributor

I ported the code to python3 and made it pip install compatible (setup.py). It is now possible to install it via:

$ pip install -e git+https://github.com/delijati/clickable
$ clickable --help

This package should also be registered on https://pypi.python.org/pypi

For further work, restructuring the package should get module aka:

- setup.py
- README.md
- clickable/
    - cli.py
    - clickable.py
    - config.py
    - ...

@jbruechert
Copy link
Copy Markdown
Contributor

The debian packaging also needs to depend on python3 then

@delijati
Copy link
Copy Markdown
Contributor Author

delijati commented Jan 18, 2018

There are tools to convert a python package (egg) to debian package:

@delijati
Copy link
Copy Markdown
Contributor Author

This could than manage the dependency to cookiecutter and its deps.

@jbruechert
Copy link
Copy Markdown
Contributor

Just replace python-cookiecutter with python3-cookiecutter
and python with python3 in debian/control

@delijati
Copy link
Copy Markdown
Contributor Author

delijati commented Jan 18, 2018

We should also add some tests. Currently changing code is like "blind flying" ;)

@bhdouglass
Copy link
Copy Markdown
Owner

Wow, this is awesome, thanks @delijati !

Splitting the code up has been on my mind every time I need to scroll up or down the code, it's been getting massive!

I see you updated the build_deb.sh script, but that won't help when building to push to the ppa & launchpad. I think you need to update the debian/install file (but @jbbgameich might have some better insight there). But it does seem like a better idea to use something to convert the python package to a deb.

Yeah, adding tests has been on my todo list, as the code is continuing to grow and it starts getting scarier to make changes!

@delijati
Copy link
Copy Markdown
Contributor Author

Updated the branch; what blocking the merge?

@bhdouglass
Copy link
Copy Markdown
Owner

@delijati I believe the outstanding issue is just the naming of the file: https://github.com/bhdouglass/clickable/blob/master/debian/clickable.install#L1
As it stands I don't believe this pull request will build a valid deb file on launchpad.

@bhdouglass
Copy link
Copy Markdown
Owner

I've merged this into the python3 branch and I'll leave this open until I get it merged fully into master and released, thanks!

@bhdouglass bhdouglass merged commit 232ed01 into bhdouglass:master Apr 5, 2018
@bhdouglass
Copy link
Copy Markdown
Owner

Finally merged this into master, look forward to a new release soon. Thanks so much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants