fix: remove windowless glass DOM when animate is false#113
Merged
Conversation
removeWindowlessGlass short-circuited on { animate: false }, splicing the
glass from the tracking array but never removing its DOM node or modal
backdrop, leaving them orphaned on document.body. Always delegate to
removeDetachedGlassElement, which removes synchronously when animate is
false — matching the sibling removeDetachedGlass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
removeWindowlessGlass(id, { animate: false })short-circuited:detachedGlassManager.removeDetachedGlass(id)only splices the glass out of the internal tracking array and returns the node — the actualglassEl.remove()(and modal backdrop removal) happens only insideremoveDetachedGlassElement. So withanimate: false, the glass shell (and any backdrop) was left orphaned ondocument.body.This surfaced in react-bwin: when
WindowProviderunmounts, its cleanup callsremoveWindowlessGlass(id, { animate: false })for each live glass. React tears down the content portal (inner content disappears) while bwin leaves the empty glass shell on screen.Fix
Drop the early return and always delegate to
removeDetachedGlassElement, which already removes the element + backdrop synchronously whenanimateis false. This matches the correct siblingremoveDetachedGlassincrud.js.Test plan
removeWindowlessGlass(id, { animate: false })— glass and any modal backdrop are removed fromdocument.body.WindowProviderwith a windowless glass open — no orphaned glass remains (dev/windowless-glass-unmount.tsx).