ci: skip dev publish when a merged PR bumps the version#118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors react-bwin's dev-publish guard.
What
check-dev-publishjob that runs on the same triggers dev-publish used (merged PR to main, or manualdev_release), diffspackage.json's version between the PR base and head, and emitsskip=truewhen the version changed.dev-publishtoneeds: check-dev-publishand gate onskip != 'true'. The triggerif:moved up to the guard job.Why
A version bump means a formal release is being prepared, so cutting an ephemeral
-dev-<sha>pre-release off that same merge is wrong. This brings bwin in line with react-bwin, which already has this guard.The
vite.config.jspath filter (bwin's, vs react-bwin's.ts) is unchanged.