Skip to content

ci: fail dev-publish guard on version bump for visibility#120

Merged
ohxyz merged 3 commits into
mainfrom
ci/fail-dev-publish-on-version-bump
Jul 1, 2026
Merged

ci: fail dev-publish guard on version bump for visibility#120
ohxyz merged 3 commits into
mainfrom
ci/fail-dev-publish-on-version-bump

Conversation

@ohxyz

@ohxyz ohxyz commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

What

Converts the check-dev-publish guard from a silent skip into a hard failure when a merged PR bumped package.json's version.

  • The guard now emits an ::error:: annotation and exit 1 instead of a ::notice:: + skip=true output.
  • Removed the now-unused outputs.skip and the if: needs.check-dev-publish.outputs.skip != 'true' gate on dev-publish — a failed needs skips it automatically.

Why

A version-bump merge previously produced a green tick in the Actions list (skipped jobs roll up to success), which reads as "published OK" when nothing published. GitHub only renders fail (red) or cancel (grey) as non-green; failing is the simplest signal with no token or extra permissions. The run now shows red with the reason in the annotation, and no dev pre-release is cut.

@ohxyz ohxyz requested a review from bhjsdev as a code owner July 1, 2026 23:31
@ohxyz ohxyz merged commit 16effb7 into main Jul 1, 2026
1 check passed
@ohxyz ohxyz deleted the ci/fail-dev-publish-on-version-bump branch July 1, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant