fix: thread minWidth/minHeight through addPane#69
Merged
Conversation
addPaneSash declared minWidth/minHeight but never passed them to the inner split helpers, so a pane added at runtime couldn't carry min-size constraints and silently differed from config-built panes. Plumb both props through Frame.addPane and BinaryWindow.addPane down to the new Sash, add coverage in pane-utils.test.js, and drop the resolved @todo and tech-debt bullet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
addPaneSashdeclaredminWidth/minHeightin its signature but never passed them to the inner split helpers (addPaneSashTo{Left,Right,Top,Bottom}), so a pane added at runtime couldn't carry min-size constraints and silently differed from config-built panes.This plumbs both props through the full call chain:
src/frame/pane-utils.js— all four split helpers accept and forwardminWidth/minHeightonto the newSash; dispatcher threads them; removed the resolved@todo.src/frame/pane.js—Frame.addPaneforwards the props.src/binary-window/binary-window.js—BinaryWindow.addPanedestructures them out before...glassPropsso they reachsuper.addPanerather than leaking into glass construction.Why
Fixes the resolved bullet of the
[low]"Unresolved design questions" tech-debt entry — updateddocs/TECH_DEBT.mdaccordingly (the remainingsash.jsandframe.jsquestions stay open).Tests
New
src/frame/pane-utils.test.js:minWidth/minHeightonto the new pane sashSashDEFAULTSFull suite green (30/30).