refactor: pass action type as bw-action-type attribute#87
Merged
Conversation
…ando Stamp custom-action buttons with a bw-action-type HTML attribute rather than a bwActionType element property; transferGlass reads it back to tell builtins from custom actions. Update conventions.md to prefer attributes for primitive stash data and reserve bwXxx properties for objects or grouped bw-data bags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stamp custom-action buttons with a
bw-action-typeHTML attribute instead of abwActionTypeelement expando property.transferGlassreads the attribute back to distinguish builtin actions from custom ones.Why
A primitive string like the action type belongs in a namespaced
bw-attribute on a native<button>— it's inspectable in the DOM and query/CSS-selectable. Element properties are reserved for object/reference values or groupedbwXxxdata bags.Also
docs/context/conventions.mdto make the attribute-first rule explicit (properties only for objects, or primitives grouped with otherbwXxxprops).chore: set vite dev server port to 7100.