feat: updatePane API — layout at frame layer + glass title/content#88
Merged
Conversation
Implements updatePane({ id, position, size, minWidth, minHeight }) on the
frame layer. Position re-places the pane keeping its relative size (same-axis
swaps with sibling, cross-axis reorients the split + rebuilds the muntin);
size resizes along the split axis like a programmatic muntin drag.
update()'s reconcile loop now calls updatePaneElement directly, freeing the
updatePane name for the new feature.
Adds a dev/features/update-pane page (two Frames, left/right and top/bottom)
to exercise position, size, and min width/height.
BinaryWindow.updatePane now updates an existing pane's glass title and
content in place (updateGlass/updateGlassTitle/updateGlassContent), on top
of the frame-layer layout update. Glass action updates are left as a TODO.
Changes the frame-layer signature to updatePane(id, { position, size,
minWidth, minHeight }); BinaryWindow.updatePane keeps its public object form.
Adds a dev/features/bwin-update-pane page (3-pane window) to exercise glass
title/content alongside position/size.
ohxyz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
updatePaneAPI to mutate an existing pane in place — both its layout (frame layer) and its glass (binary-window layer).Frame layer —
updatePane(id, { position, size, minWidth, minHeight })update()'s reconcile loop now callsupdatePaneElementdirectly, freeing theupdatePanename for the new feature.Binary-window layer —
updatePane({ id, ..., title, content })updateGlass/updateGlassTitle/updateGlassContent), on top of the frame-layer layout update.Dev pages
update-pane— two Frames (left/right and top/bottom) to exercise position, size, and min width/height.bwin-update-pane— a 3-pane BinaryWindow to exercise glass title/content alongside position/size.