refactor: make detachedGlassManager the single point for detached-glass lifecycle#92
Merged
Merged
Conversation
…ss lifecycle
- addDetachedGlass builds the DetachedGlass, registers + brings to front, plays
the open animation, and returns the glass element (callers own only the DOM
append).
- removeDetachedGlass owns the full teardown (unregister + remove node/backdrop)
and takes an { animateClose } options object.
- updateDetachedGlass added as a tentative stub.
- Guard against duplicate ids in the stack; add getDetachedGlassById.
- Migrate crud/binary-window/action callers; add manager.test.js.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralizes the detached-glass lifecycle behind
detachedGlassManager, the single entry point for add/remove/update across both in-window and windowless glasses.addDetachedGlass(options)— builds theDetachedGlass, registers + brings to front, plays the open animation; returns the glass element (callers own only the DOMappend).removeDetachedGlass(id, { animateClose })— owns the full teardown: unregister and remove the DOM node + modal backdrop.updateDetachedGlass(id, options)— tentative stub (throws).getDetachedGlassById.crud.js/binary-window.js/action.close.js/action.detach.js; addsmanager.test.js.Also fixes a latent missing-import bug in
removeWindowlessGlass.addDetachedGlass/addWindowlessGlassnow return the glass element rather than theDetachedGlassinstance — downstreamreact-bwinmay need updating.Test plan
npm test— 48 passing (6 files), incl. newmanager.test.js(18 cases).npm run build— clean.