refactor: make updatePane take paneSashId as first positional arg#93
Merged
Conversation
Aligns updatePane with addPane(targetPaneSashId, props). Adds tests for the new signature and moves the normActions tests to utils.test.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Change
BinaryWindow#updatePanefromupdatePane({ id, ...props })toupdatePane(paneSashId, { position, size, minWidth, minHeight, title, content }).Why
Aligns the signature with the sibling
addPane(targetPaneSashId, props), making the id an explicit positional argument rather than a property mixed into the options bag.Changes
src/binary-window/binary-window.js— new signature; options object defaults to{}.dev/window/bwin-update-pane.js— updated caller toupdatePane(id, props).src/binary-window/binary-window.test.js— newupdatePanesuite (positional id, isolation, layout path, error path, optional options).src/binary-window/utils.test.js— moved thenormActionstests here.