feat: animate detached glass shrinking into its sill pot on minimize#96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Minimizing a detached glass now animates it shrinking and flying toward its sill pot before disappearing, instead of cutting out instantly.
How
animateElementToElement(sourceEl, targetEl, onDone)insrc/animate.js— a FLIP-style flight (translate + scale + fade via the Web Animations API) that maps a source element's top-left corner onto a target element's, then runsonDone.detached-glass/action.minimize.jsdefers itsdisplay: noneinto the animation'sonDonecallback.The util is intentionally generic so the attached-glass minimize action can reuse it next.