fix: let an off-screen detached glass drag back toward the viewport#97
Merged
Conversation
When a glass sat outside the viewport (e.g. after a browser resize), the first drag snapped it inside because the bounds were clamped to the current viewport. Track the last applied position and relax only the breached edge to it, so an off-screen glass can move toward the viewport but never further out, and re-engages the normal viewport clamp once back inside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a detached glass sat outside the viewport (e.g. after a browser resize), the first drag snapped it inside because the move bounds were clamped to the current viewport.
clampAxishelper, relax only the breached edge to it — an off-screen glass can move toward the viewport but never further out, and the normal viewport clamp re-engages once it's back inside.move.jsdocuments a known minor edge case: bounds are frozen per-grab, so a glass that showed a scrollbar reserves that width as it drags back until the next grab.Docs
conventions.md: note the pattern of splitting long multi-concern comments into-bullets.ARCHITECTURE.md: note the off-screen drag recovery in themove.jsrow.