expose hedge stats via Prometheus-style /metrics handler#16
Open
batazor wants to merge 1 commit intobhope:mainfrom
Open
expose hedge stats via Prometheus-style /metrics handler#16batazor wants to merge 1 commit intobhope:mainfrom
batazor wants to merge 1 commit intobhope:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a Prometheus-compatible metrics exposition path for hedge.Stats, enabling consumers to scrape hedge transport counters via an HTTP /metrics endpoint.
Changes:
- Extend
StatswithWritePrometheus(io.Writer)andServeHTTP(http.ResponseWriter, *http.Request)for Prometheus text exposition. - Make
Snapshot()/HedgeRate()nil-safe. - Add HTTP handler tests and document
/metricsusage in the README.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| stats.go | Implements Prometheus text exposition output and an HTTP handler on Stats. |
| hedge_test.go | Adds tests covering /metrics GET and method-not-allowed behavior. |
| README.md | Documents how to mount stats as a Prometheus-style /metrics endpoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
09fb1b7 to
999db6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2