Skip to content

updated dependencies and tests to support vite 6; added typescript support#394

Merged
bienzaaron merged 16 commits into
bienzaaron:mainfrom
zphrs:main
Jun 14, 2025
Merged

updated dependencies and tests to support vite 6; added typescript support#394
bienzaaron merged 16 commits into
bienzaaron:mainfrom
zphrs:main

Conversation

@zphrs

@zphrs zphrs commented May 30, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@zphrs zphrs changed the title updated dependencies and tests to support vite 6 updated dependencies and tests to support vite 6; added typescript support May 31, 2025
@zphrs

zphrs commented May 31, 2025

Copy link
Copy Markdown
Contributor Author

If anyone sees this PR and wants to use this branch before it's merged into main and published to npm, feel free to run

npm install https://github.com/zphrs/vite-plugin-inline-source#build

This also works with pnpm and yarn with their respective add commands.

@kale5in

kale5in commented Jun 10, 2025

Copy link
Copy Markdown

I think to get this PR approved faster, you should split it into three separate pull requests. This would save a lot of time for the person reviewing the code.

1.	Vite 6 support
2.	Dependency updates
3.	TypeScript support

@zphrs

zphrs commented Jun 11, 2025

Copy link
Copy Markdown
Contributor Author

I think to get this PR approved faster, you should split it into three separate pull requests. This would save a lot of time for the person reviewing the code.

1.	Vite 6 support
2.	Dependency updates
3.	TypeScript support

If @bienzaaron wants me to do so, I will. Note however that dependencies had to be updated in order to have Vite 6 support.

I agree including typescript support with the Vite 6 support is somewhat disorganized. That said, if @bienzaaron wants to merge in the two separately then they can merge in 40319ce for Vite 6 support and then merge in this PR for typescript support.

@bienzaaron

Copy link
Copy Markdown
Owner

Hey there, sorry I have been doing a poor job of maintenance with this library lately.

Thanks for sending a PR! I'll take a look this evening.

@bienzaaron bienzaaron merged commit 7df7708 into bienzaaron:main Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants