Stub any_instance of Interceptor#8
Merged
prathamesh-sonpatki merged 1 commit intobigbinary:masterfrom Jan 23, 2015
Merged
Conversation
Add default stub to set env to ‘test’ so that you only have to override that if you want it to be something different. This fixes a failure in the tests I was experiencing because test_subject_prefix_in_production couldn’t stub env until the interceptor was instantiated, but the initializer tests for production? in the sanitize_forward_emails_to method called in the initializer.
Contributor
|
Looks good. Thanks. |
prathamesh-sonpatki
added a commit
that referenced
this pull request
Jan 23, 2015
Stub any_instance of Interceptor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add default stub to set env to ‘test’ so that you only have to override
that if you want it to be something different.
This fixes a failure in the tests I was experiencing because
test_subject_prefix_in_production couldn’t stub env until the
interceptor was instantiated, but the initializer tests for production?
in the sanitize_forward_emails_to method called in the initializer.